Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to execute from the root of the repo #1674

Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented May 1, 2024

Description

  • Update top-level examples and Triton start-up commands to execute from the root of the repo
  • Where possible set default values for cli flags, removing the need to set them for the common use-case
  • Where possible remove the need for defining MORPHEUS_ROOT
  • Ensure C++ Triton pipelines use port 8000 to avoid the warning about the grpc port.
  • Optionally cast types in the C++ impl of the Triton stage when force_convert_inputs=true and the input and model types didn't match (previously types were always casted)
  • Remove --num_threads=1 restriction and configure logging for the log_parsing example
  • Remove --num_threads=8 restriction from nlp_si_detection since the pipeline has more than 8 stages.
  • Don't invoke the C++ impl of preallocate if the type being requested isn't supported on the C++ side (strings)
  • Don't use the C++ impl of the Triton stage if use_shared_memory is requested as this isn't supported in C++.
  • Add missing gnn-fraud-classification stage to CLI alternative for gnn_fraud_detection_pipeline example

Closes #1671

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv self-assigned this May 1, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner May 1, 2024 14:58
@dagardner-nv dagardner-nv added non-breaking Non-breaking change doc Improvements or additions to documentation labels May 1, 2024
@dagardner-nv dagardner-nv marked this pull request as draft May 1, 2024 14:59
@dagardner-nv dagardner-nv marked this pull request as ready for review May 1, 2024 18:03
@dagardner-nv dagardner-nv requested a review from pdmack May 1, 2024 18:53
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing the --force_convert_inputs lets pass the variable down and check if its needed. If they dont match, either throw an exception or pass to triton unchanged. Follow the python implementation.

morpheus/_lib/include/morpheus/objects/dtype.hpp Outdated Show resolved Hide resolved
morpheus/stages/inference/triton_inference_stage.py Outdated Show resolved Hide resolved
@dagardner-nv dagardner-nv marked this pull request as draft May 1, 2024 21:35
@dagardner-nv dagardner-nv added the skip-ci Optionally Skip CI for this PR label May 1, 2024
@dagardner-nv dagardner-nv removed the skip-ci Optionally Skip CI for this PR label May 2, 2024
@dagardner-nv dagardner-nv marked this pull request as ready for review May 2, 2024 20:21
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 808c52c into nv-morpheus:branch-24.06 May 2, 2024
14 checks passed
@dagardner-nv dagardner-nv deleted the examples-in-root-1671 branch May 2, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[DOC]: Update examples to run from project root
3 participants