Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable C++ mode for abp_pcap_detection example #1687

Merged
merged 36 commits into from
May 8, 2024
Merged

Enable C++ mode for abp_pcap_detection example #1687

merged 36 commits into from
May 8, 2024

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented May 3, 2024 •
edited
Loading

Description

  • Update the pcap-preprocess stage to ensure tensors are in row major as required by Triton.
  • Update the pcap-preprocess stage to cast float64 data to model's expected input of float32, removing the need to specify force_convert_inputs. Since this stage is specific to this pipeline & model.

Closes #1675

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv
Update abp_pcap_detection example to be runnable from the project root
4d27cbe
@dagardner-nv
Enable running the GNN fraud pipeline from the root of the Morpheus repo
3fd330d
@dagardner-nv
Remove unnescesary --num_threads=1, remove need for setting MORPHEUS_…
6c1d80e 
…ROOT
@dagardner-nv
Don't set flags where a reasonable default exists
aae1664
@dagardner-nv
Add helper method to check if a typeid is fully supported in C++
3231572
@dagardner-nv
Only build a C++ node if all of the types are supported in C++
89bb5a7
@dagardner-nv
Don't construct a C++ node if either force_convert_inputs or use_shar…
ba503e9 
…ed_memory is true
@dagardner-nv
Don't disable C++ mode
68bfa3c
@dagardner-nv
Don't disable C++ mode
8dee598
@dagardner-nv
Don't set threads to 8, since we have 9 stages. Update port num to th…
0d1c49d 
…e grpc port since we're using the python impl now
@dagardner-nv
Support running the ransomeware example from the root of the repo
2e7e1e4
@dagardner-nv
Remove the --force_convert_inputs=True flag this isn't needed and jus…
ebfec0f 
…t causes a float32 vs float64 error in the add-scores stage
@dagardner-nv
Remove unused import
4ebb47f
@dagardner-nv
Only force python for shared mem
60cf6ed
@dagardner-nv
Not sure why, but this pipeline returns different results in C++ mode
3ca7f07
@dagardner-nv
Revert port-change
20ea8b2
@dagardner-nv
Use port 8000 to avoid warning about port change
b869c35
@dagardner-nv
Add missing gnn-fraud-classification stage
5458c41
@dagardner-nv
Remove setting MORPHEUS_ROOT
df2a4b7
@dagardner-nv
Merge adjacent shell blocks
ab2a996
@dagardner-nv
Remove reference to the data dir, as we just have two csv files
1840ed1
@dagardner-nv
Remove --force_convert_inputs=True flag since implicit casting is alw…
f0641f1 
…ays enabled for C++ mode
@dagardner-nv
Remove --force_convert_inputs=True flag since implicit casting is alw…
c49d3a7 
…ays enabled for C++ mode
@dagardner-nv
Add test for is_fully_supported
3931259
@dagardner-nv
Add missing includes
20ba1cc
@dagardner-nv
Merge branch 'branch-24.06' into abp_pcap_detection-1675
08db18d
@dagardner-nv
Revert "Remove --force_convert_inputs=True flag since implicit castin…
ca4179b 
…g is always enabled for C++ mode"

This reverts commit f0641f1.
@dagardner-nv
Revert "Remove --force_convert_inputs=True flag since implicit castin…
ced6be0 
…g is always enabled for C++ mode"

This reverts commit c49d3a7.
@dagardner-nv
Remove redundant call to cp.asarray, explicitly cast to the model's i…
4e424ec 
…nput type
@dagardner-nv
Remove unused kwargs
eb2d2d9
@dagardner-nv dagardner-nv requested a review from a team as a code owner May 3, 2024 20:42
@dagardner-nv dagardner-nv self-assigned this May 3, 2024
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels May 3, 2024
@mdemoret-nv mdemoret-nv changed the title Enable C++ mode for abp_pcap_detection example Enable C++ mode for abp_pcap_detection example May 8, 2024
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 78dab99 into nv-morpheus:branch-24.06 May 8, 2024
13 checks passed
@dagardner-nv dagardner-nv deleted the abp_pcap_detection-1675 branch May 8, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: abp_pcap_detection example should run in C++ mode
2 participants
@dagardner-nv @mdemoret-nv