Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the filter_null parameter in the C++ impl of the FileSourceStage #1689

Merged
merged 17 commits into from
May 9, 2024
Merged

Support the filter_null parameter in the C++ impl of the FileSourceStage #1689

merged 17 commits into from
May 9, 2024

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented May 6, 2024 •
edited
Loading

Description

  • Fixes bug where the filter_null constructor argument to the FileSourceStage was only implemented in the Python impl of the stage.
  • Update filter_null feature to make the column(s) being filtered upon configurable, previously this was hard-coded to "data"
  • Add new get_column_names helper method to CuDFTableUtil

Closes #1678

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner May 6, 2024 20:01
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels May 6, 2024
@dagardner-nv dagardner-nv self-assigned this May 6, 2024
@dagardner-nv dagardner-nv marked this pull request as draft May 6, 2024 20:02
@dagardner-nv dagardner-nv added the skip-ci Optionally Skip CI for this PR label May 6, 2024
@dagardner-nv dagardner-nv removed the skip-ci Optionally Skip CI for this PR label May 6, 2024
@dagardner-nv dagardner-nv marked this pull request as ready for review May 6, 2024 20:15
mdemoret-nv
mdemoret-nv approved these changes May 8, 2024
View reviewed changes
morpheus/_lib/src/stages/file_source.cpp Outdated Show resolved Hide resolved
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit bf80d93 into nv-morpheus:branch-24.06 May 9, 2024
11 checks passed
@dagardner-nv dagardner-nv deleted the filter_null_cpp-1678 branch May 9, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: filter_null arg to FileSourceStage ignored by C++ impl
2 participants
@dagardner-nv @mdemoret-nv