Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix description for cache_mode option of DFP Rolling Window module #1707

Merged
merged 2 commits into from
May 29, 2024

Conversation

efajardo-nv
Copy link
Contributor

Description

  • Fix description for cache_mode option of DFP Rolling Window module. It was using description for fallback_username in multiple places.

Closes #1696

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@efajardo-nv efajardo-nv added non-breaking Non-breaking change doc Improvements or additions to documentation labels May 16, 2024
@efajardo-nv efajardo-nv self-assigned this May 16, 2024
@efajardo-nv efajardo-nv requested a review from a team as a code owner May 16, 2024 22:26
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit e136ab2 into nv-morpheus:branch-24.06 May 29, 2024
12 checks passed
@mdemoret-nv mdemoret-nv deleted the fix-cache-mod-descrs branch May 29, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

The cache_mode description in DFP docs is incorrect
2 participants