Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate deprecation warning for MultiMessage #1719

Merged
merged 11 commits into from
May 31, 2024
Merged

Generate deprecation warning for MultiMessage #1719

merged 11 commits into from
May 31, 2024

Conversation

yczhang-nv
Copy link
Contributor

Description

  • Generate deprecation warning for any usage of MultiMessage
  • Update documentation to illustrate conversion from MultiMessage to ControlMessage

Closes #1718

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@yczhang-nv yczhang-nv self-assigned this May 22, 2024
@yczhang-nv yczhang-nv requested a review from a team as a code owner May 22, 2024 22:02
@yczhang-nv yczhang-nv added non-breaking Non-breaking change improvement Improvement to existing functionality labels May 22, 2024
dagardner-nv
dagardner-nv reviewed May 24, 2024
View reviewed changes
docs/source/developer_guide/guides/9_control_messages.md Show resolved Hide resolved
morpheus/messages/message_base.py Outdated Show resolved Hide resolved
morpheus/messages/message_base.py Outdated Show resolved Hide resolved
tests/test_multi_message.py Show resolved Hide resolved
mdemoret-nv
mdemoret-nv approved these changes May 29, 2024
View reviewed changes
tests/test_logger.py Outdated Show resolved Hide resolved
tests/test_multi_message.py Outdated Show resolved Hide resolved
morpheus/utils/logger.py Outdated Show resolved Hide resolved
@yczhang-nv yczhang-nv force-pushed the yuchen-deprecate-message-for-multi-message branch from 1abf932 to d011acf Compare May 29, 2024 21:34
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 580be43 into nv-morpheus:branch-24.06 May 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagardner-nv dagardner-nv dagardner-nv left review comments

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@yczhang-nv yczhang-nv

Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Add deprecation message for MultiMessage
3 participants
@yczhang-nv @mdemoret-nv @dagardner-nv