Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce multi-endpoint servers and health check endpoints to HttpServerSourceStage #1734

Merged

Conversation

jadu-nv
Copy link
Contributor

@jadu-nv jadu-nv commented Jun 12, 2024

Description

Addresses: #1732

Currently, the HttpServer implementation does not support the initialization of a single server with multiple endpoints. This PR seeks to address this issue by refactoring the HttpServer by taking a list of HttpEndpoint objects (encapsulates the attributes of an http endpoint, ie. url, method, endpoint handler).

Additionally, this PR also introduces 2 endpoints to HttpServerSourceStage that allows users to conduct health checks on their pipelines.

  • GET /live -> Immediately returns a 200 response if the server is alive
  • GET /ready -> Immediately returns a 200 response if the server is ready to accept new messages

These endpoints are configurable by the user.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@jadu-nv jadu-nv added breaking Breaking change feature request New feature or request labels Jun 12, 2024
@jadu-nv jadu-nv marked this pull request as ready for review June 12, 2024 23:01
@jadu-nv jadu-nv requested a review from a team as a code owner June 12, 2024 23:01
@jadu-nv jadu-nv self-assigned this Jun 13, 2024
@jadu-nv jadu-nv force-pushed the jadu-http-server-source-endpoints branch from 5eb5de2 to 68e7a8d Compare June 16, 2024 18:15
Copy link

copy-pr-bot bot commented Jun 16, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mdemoret-nv
Copy link
Contributor

/ok to test

@jadu-nv
Copy link
Contributor Author

jadu-nv commented Jun 26, 2024

/ok to test

1 similar comment
@dagardner-nv
Copy link
Contributor

/ok to test

@dagardner-nv
Copy link
Contributor

/ok to test

@dagardner-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 18eca56 into nv-morpheus:branch-24.06 Jun 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change feature request New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants