Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always run the PR builder step even if others are cancelled #1736

Merged

Conversation

mdemoret-nv
Copy link
Contributor

Description

  • This forces the pr-builder step to always be run. Since this is a required step in order to merge a PR, we want to make sure it is always run.
  • This is needed since we skip some steps in CI by default which causes the pr-builder step to be skipped as well.

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@mdemoret-nv mdemoret-nv added non-breaking Non-breaking change improvement Improvement to existing functionality labels Jun 14, 2024
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner June 14, 2024 14:12
@mdemoret-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 0b284b5 into nv-morpheus:branch-24.06 Jun 14, 2024
15 checks passed
@mdemoret-nv mdemoret-nv deleted the mdd_always-run-pr-builder branch June 14, 2024 17:35
AnuradhaKaruppiah added a commit to AnuradhaKaruppiah/Morpheus that referenced this pull request Aug 23, 2024
rapids-bot bot pushed a commit that referenced this pull request Aug 23, 2024
…celled" (#1860)

CIs are failing because of #1736 not playing well with  rapidsai/shared-workflows#237

As a stopgap I am reverting the changes in #1736

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: #1860
dagardner-nv pushed a commit to dagardner-nv/Morpheus that referenced this pull request Aug 23, 2024
…celled" (nv-morpheus#1860)

CIs are failing because of nv-morpheus#1736 not playing well with  rapidsai/shared-workflows#237

As a stopgap I am reverting the changes in nv-morpheus#1736

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: nv-morpheus#1860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants