Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix triton multi threading when using the C++ stage #1739

Merged

Conversation

mdemoret-nv
Copy link
Contributor

Description

  • In 24.03, multi threading had to be disabled in the Triton C++ stage due to a race condition.
  • This PR changes the client to use fiber local storage so multiple fibers can be running with different clients at the same time
  • Allows increasing the pe_count of the stage beyond 1

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change labels Jun 14, 2024
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner June 14, 2024 17:26
@dagardner-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 8095a76 into nv-morpheus:branch-24.06 Jun 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants