Fixes for C++ impl for DeserializeStage and add missing get_info overloads to SlicedMessageMeta
#1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
self.supports_cpp_node()withself._build_cpp_node()inDeserializeStageto determine if a C++ impl should be used._stages.DeserializeControlMessageStageor_stages.DeserializeMultiMessageStagebased on the message type (likely this was a merge error).get_info(const std::string&)andget_info(const std::vector<std::string>&)toSlicedMessageMetawhich indirectly fixes the cuda memory errors in [BUG]: C++ Implementation of Deserialize is broken #1747Closes #1747
By Submitting this PR I confirm: