Provide a default set of questions for the standalone RAG pipeline #1758

dagardner-nv · 2024-06-24T19:05:52Z

Description

PR DOCA stage split: source + convert #1617 replaced the hard-coded questions with a command-line-flag, however it was not given a default value nor was it marked as a required flag.
Set the original question as the default value for the flag

Requires #1755
Closes #1757

I am familiar with the Contributing Guidelines.
When the PR is ready for review, new or existing tests cover these changes.
When the PR is ready for review, the documentation is up to date with these changes.

…thout one

dagardner-nv · 2024-06-24T22:41:49Z

/merge

dagardner-nv added 4 commits June 24, 2024 11:22

Don't use shared mem, triton cpp impl doesn't support it

0c02dc8

Don't use shared mem, triton cpp impl doesn't support it

8469214

Restore the default source type to rss

6b9054a

Give the --question flag a default values since the pipeline fails wi…

5350104

…thout one

dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Jun 24, 2024

dagardner-nv self-assigned this Jun 24, 2024

dagardner-nv requested a review from a team as a code owner June 24, 2024 19:05

dagardner-nv added the Merge After Dependencies PR is completed and reviewed but depends on another PR; do not merge out of order label Jun 24, 2024

mdemoret-nv approved these changes Jun 24, 2024

View reviewed changes

rapids-bot bot merged commit b214137 into nv-morpheus:branch-24.06 Jun 24, 2024
15 checks passed

dagardner-nv deleted the david-rag-standalone-questions-1757 branch June 24, 2024 22:41