Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fetch data command in build_container_release.sh #1787

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

ifengw-nv
Copy link
Contributor

Description

Closes #1773

Add fetch_data.py script prior to performing the container build, since a valid release container includes example data and models

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@ifengw-nv ifengw-nv requested a review from a team as a code owner July 1, 2024 22:19
Copy link

copy-pr-bot bot commented Jul 1, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ifengw-nv ifengw-nv added the Needs Triage Need team to review and classify label Jul 1, 2024
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change and removed Needs Triage Need team to review and classify labels Jul 1, 2024
@dagardner-nv
Copy link
Contributor

/ok to test

@dagardner-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit c576308 into nv-morpheus:branch-24.06 Jul 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEA]: docker/build_container_release.sh should call scripts/fetch_data.py
2 participants