Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all use cases of MultiMessage from stages #1803

Open
wants to merge 82 commits into
base: branch-24.10
Choose a base branch
from
Open

Remove all use cases of MultiMessage from stages #1803

wants to merge 82 commits into from

Conversation

yczhang-nv
Copy link
Contributor

@yczhang-nv yczhang-nv commented Jul 8, 2024 •
edited
Loading

Description

Remove all use cases of MultiMessage from the following stages:

  • add_scores_stage_base
  • add_scores
  • add_classification
  • inference
  • preprocess_fil
  • preprocess_nlp
  • preprocess_ae
  • serialize
  • filter_detections
  • generate_viz_frames
  • ml_flow_drift
  • timeseries
  • validation

Closes #1802

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@yczhang-nv yczhang-nv added breaking Breaking change improvement Improvement to existing functionality labels Jul 8, 2024
@yczhang-nv yczhang-nv self-assigned this Jul 8, 2024
@yczhang-nv yczhang-nv requested a review from a team as a code owner July 8, 2024 19:05
@yczhang-nv yczhang-nv marked this pull request as draft July 8, 2024 19:05
@yczhang-nv
Remove MultiMessage from AddScoresStage python impl & reformatting
bb18d7e
@yczhang-nv
fix test errors
6500db8
@yczhang-nv
remove from preprocess_nlp cpp impl
6402965
@yczhang-nv
remove from preprocess_nlp python impl
7a53076
@yczhang-nv
remove from preprocess_fil cpp impl
f4f97bd
@yczhang-nv
remove from preprocess_fil python impl
9e8b2c5
@yczhang-nv
remove from preprocess_ae impl
0bbadbc
@yczhang-nv
remove from serialize stage impl
a960468
@yczhang-nv
remove from filter_detections impl
5c45b62
@yczhang-nv
remove from filter_detections_controller
6ea61b8
@yczhang-nv
remove from generate_viz_frames
81ccd6e
@yczhang-nv
remove from mlflow_drift_stage
fecd7e0
@yczhang-nv
remove from timeseries stage
4a572c9
@yczhang-nv
remove from validation stage
3e3ad14
@yczhang-nv
update deserialize stage
fa3d971
@yczhang-nv
fix some unit tests
30a76a2
@yczhang-nv
fix unit tests
6629139
@yczhang-nv
fix inference
746530c
@yczhang-nv
update fil stage
f0dbfc0
@yczhang-nv
rollback to test triton_inference_stage
46217dc
@yczhang-nv
test cm for test_inference_stage
72171fa
@yczhang-nv
passed test_triton_inference_stage
3753707
@yczhang-nv
fix
b6509f0
@yczhang-nv
debugging test_dfp.py
bddaf5f
@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

@yczhang-nv
Copy link
Contributor Author

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagardner-nv dagardner-nv dagardner-nv requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@yczhang-nv yczhang-nv

Labels
breaking Breaking change improvement Improvement to existing functionality
Projects
Morpheus Boards
Status: Review - Changes Requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Remove all use cases of MultiMessage from stages
2 participants
@yczhang-nv @dagardner-nv