Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the release container does not contain any unintended files #1807

Merged
merged 13 commits into from
Jul 31, 2024
Merged

Ensure the release container does not contain any unintended files #1807

merged 13 commits into from
Jul 31, 2024

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jul 11, 2024 •
edited
Loading

Description

  • Rather than copy directly from the host's repo, perform a git clone ensuring that any local build artifacts or uncommitted changes don't find their way into the release image.

Closes #1769

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change labels Jul 11, 2024
@dagardner-nv dagardner-nv self-assigned this Jul 11, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner July 11, 2024 00:10
@dagardner-nv dagardner-nv added the Merge After Dependencies PR is completed and reviewed but depends on another PR; do not merge out of order label Jul 11, 2024
mdemoret-nv
mdemoret-nv requested changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement but I think this could be simplified a bit with a local clone from another director

docker/Dockerfile Outdated Show resolved Hide resolved
docker/build_container_release.sh Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
@dagardner-nv dagardner-nv removed the Merge After Dependencies PR is completed and reviewed but depends on another PR; do not merge out of order label Jul 25, 2024
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5e0d920 into nv-morpheus:branch-24.10 Jul 31, 2024
13 checks passed
@dagardner-nv dagardner-nv deleted the david-clean-clone branch July 31, 2024 20:24
@ashsong-nv ashsong-nv mentioned this pull request Aug 27, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Release container potentially includes unneeded files
2 participants
@dagardner-nv @mdemoret-nv