Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build time user and uid/gid #533

Draft
wants to merge 7 commits into
base: branch-23.11
Choose a base branch
from

Conversation

pdmack
Copy link
Contributor

@pdmack pdmack commented Dec 8, 2022

Picks up from #68
Closes #22

Notes:

  • can specify an arbitrary user, uid/gid when building release image
  • default is still root (0:0)
  • docker run --user ... with an arbitrary uid/gid still allows that user to run the CLI tool
  • smoke tested with file-based DFP inf-pytorch pipeline

Unresolved questions:

  • should the build uid even be a sudoer?

@pdmack pdmack added enhancement Additional functionality added to an existing feature breaking Breaking change improvement Improvement to existing functionality DO NOT MERGE PR should not be merged; see PR for details labels Dec 8, 2022
@mdemoret-nv mdemoret-nv changed the base branch from branch-23.01 to branch-23.11 July 14, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change DO NOT MERGE PR should not be merged; see PR for details enhancement Additional functionality added to an existing feature improvement Improvement to existing functionality
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[FEA] Add ability to build containers that default to a user other than root.
5 participants