Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spring and factorialize #45

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Jun 14, 2024

PR-Codex overview

This PR focuses on optimizing the factorial calculation implementation in the Factorial class and updating the Spring Boot application to utilize this optimized implementation.

Detailed summary

  • Replaced A class with Factorial class for factorial calculations.
  • Updated Main class to use Factorial objects.
  • Added MIT license headers to Factorial and FactorialApplication classes.
  • Updated Spring Boot application entry point to use Factorial objects.
  • Increased the total in the Makefile to 10,000,000.
  • Updated versions of EO libraries.

The following files were skipped due to too many changes: Makefile, pom.xml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jun 17, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit d1882a1 into objectionary:master Jun 17, 2024
2 checks passed
@rultor
Copy link
Contributor

rultor commented Jun 17, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 9min)

@0crat
Copy link

0crat commented Jul 5, 2024

@maxonfjvipon Thanks for the contribution! You've earned +20 points for this. Please, keep them coming. .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants