Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FuseMojo.sourcesDir is defined too globally #32

Closed
yegor256 opened this issue Dec 25, 2023 · 3 comments
Closed

FuseMojo.sourcesDir is defined too globally #32

yegor256 opened this issue Dec 25, 2023 · 3 comments
Assignees
@maxonfjvipon
Labels
bug Something isn't working

Comments

@yegor256
Copy link
Member

This is wrong: https://github.com/objectionary/ineo-maven-plugin/blob/master/src/main/java/org/eolang/ineo/FuseMojo.java#L77

Instead of ${basedir} we should use ${project.build.outputDirectory}, because basedir is not configurable from the outside, while the outputDirectory is configured through pom.xml.
@yegor256 yegor256 added the bug Something isn't working label Dec 25, 2023
@yegor256
Copy link
Member Author

@maxonfjvipon because of this bug, we have this error: https://github.com/objectionary/benchmark/actions/runs/7322657817/job/19944413128 Please, fix asap

maxonfjvipon added a commit to maxonfjvipon/ineo-maven-plugin that referenced this issue Dec 25, 2023
@maxonfjvipon
fix(objectionary#32): new BA + IT + directory + log
ea8be22
@maxonfjvipon maxonfjvipon mentioned this issue Dec 25, 2023
Merged
@maxonfjvipon
Copy link
Member

@yegor256 tried to fixed in #33. Please check again

@yegor256
Copy link
Member Author

@maxonfjvipon thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxonfjvipon maxonfjvipon

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yegor256 @maxonfjvipon