Merge pull request #208 from observerly/fix/header/SIMPLE

feat: Amend { SIMPLE } HDU Value to "T" to validate against CCFITSio.

coverage.txt

@@ -222,15 +222,15 @@ github.com/observerly/iris/pkg/statistics/stats.go:193.24,198.3 3 770008
 github.com/observerly/iris/pkg/statistics/stats.go:202.2,204.11 2 5
 github.com/observerly/iris/pkg/statistics/stats.go:218.100,224.24 3 3
 github.com/observerly/iris/pkg/statistics/stats.go:224.24,226.7 2 769000
-github.com/observerly/iris/pkg/statistics/stats.go:226.7,229.43 2 769097
+github.com/observerly/iris/pkg/statistics/stats.go:226.7,229.43 2 769088
 github.com/observerly/iris/pkg/statistics/stats.go:229.43,230.10 1 769000
 github.com/observerly/iris/pkg/statistics/stats.go:234.3,234.16 1 769000
 github.com/observerly/iris/pkg/statistics/stats.go:237.2,239.15 2 3
 github.com/observerly/iris/pkg/statistics/stats.go:253.96,259.24 3 3
 github.com/observerly/iris/pkg/statistics/stats.go:259.24,262.7 2 769000
-github.com/observerly/iris/pkg/statistics/stats.go:262.7,266.43 3 769255
-github.com/observerly/iris/pkg/statistics/stats.go:266.43,267.13 1 150
-github.com/observerly/iris/pkg/statistics/stats.go:270.4,271.45 2 769105
+github.com/observerly/iris/pkg/statistics/stats.go:262.7,266.43 3 769162
+github.com/observerly/iris/pkg/statistics/stats.go:266.43,267.13 1 101
+github.com/observerly/iris/pkg/statistics/stats.go:270.4,271.45 2 769061
 github.com/observerly/iris/pkg/statistics/stats.go:271.45,272.10 1 769000
 github.com/observerly/iris/pkg/statistics/stats.go:276.3,276.50 1 769000
 github.com/observerly/iris/pkg/statistics/stats.go:281.2,283.11 2 3
@@ -349,19 +349,19 @@ github.com/observerly/iris/pkg/fits/header.go:305.33,313.3 1 10
 github.com/observerly/iris/pkg/fits/header.go:316.2,316.36 1 65
 github.com/observerly/iris/pkg/fits/header.go:316.36,324.3 1 0
 github.com/observerly/iris/pkg/fits/header.go:326.2,326.12 1 65
-github.com/observerly/iris/pkg/fits/header.go:330.69,331.18 1 2
+github.com/observerly/iris/pkg/fits/header.go:330.69,331.18 1 12
 github.com/observerly/iris/pkg/fits/header.go:331.18,333.3 1 0
-github.com/observerly/iris/pkg/fits/header.go:335.2,335.23 1 2
+github.com/observerly/iris/pkg/fits/header.go:335.2,335.23 1 12
 github.com/observerly/iris/pkg/fits/header.go:335.23,337.3 1 0
-github.com/observerly/iris/pkg/fits/header.go:340.2,343.11 2 2
-github.com/observerly/iris/pkg/fits/header.go:343.11,345.3 1 2
-github.com/observerly/iris/pkg/fits/header.go:347.2,347.55 1 2
-github.com/observerly/iris/pkg/fits/header.go:351.59,352.18 1 60
+github.com/observerly/iris/pkg/fits/header.go:340.2,343.11 2 12
+github.com/observerly/iris/pkg/fits/header.go:343.11,345.3 1 12
+github.com/observerly/iris/pkg/fits/header.go:347.2,347.55 1 12
+github.com/observerly/iris/pkg/fits/header.go:351.59,352.18 1 50
 github.com/observerly/iris/pkg/fits/header.go:352.18,354.3 1 0
-github.com/observerly/iris/pkg/fits/header.go:355.2,355.23 1 60
+github.com/observerly/iris/pkg/fits/header.go:355.2,355.23 1 50
 github.com/observerly/iris/pkg/fits/header.go:355.23,357.3 1 10
-github.com/observerly/iris/pkg/fits/header.go:360.2,362.22 2 60
-github.com/observerly/iris/pkg/fits/header.go:362.22,364.3 1 47
+github.com/observerly/iris/pkg/fits/header.go:360.2,362.22 2 50
+github.com/observerly/iris/pkg/fits/header.go:362.22,364.3 1 37
 github.com/observerly/iris/pkg/fits/header.go:364.8,369.23 3 13
 github.com/observerly/iris/pkg/fits/header.go:369.23,372.4 2 0
 github.com/observerly/iris/pkg/fits/header.go:374.3,374.85 1 13
@@ -429,7 +429,7 @@ github.com/observerly/iris/pkg/photometry/stars.go:67.101,73.2 3 2
 github.com/observerly/iris/pkg/photometry/stars.go:80.97,111.2 13 1
 github.com/observerly/iris/pkg/photometry/stars.go:121.119,125.25 2 95855
 github.com/observerly/iris/pkg/photometry/stars.go:125.25,129.39 2 862695
-github.com/observerly/iris/pkg/photometry/stars.go:129.39,132.4 2 862233
+github.com/observerly/iris/pkg/photometry/stars.go:129.39,132.4 2 862241
 github.com/observerly/iris/pkg/photometry/stars.go:135.2,137.23 2 95855
 github.com/observerly/iris/pkg/photometry/stars.go:148.89,152.25 2 7
 github.com/observerly/iris/pkg/photometry/stars.go:152.25,153.20 1 10253216
@@ -442,62 +442,62 @@ github.com/observerly/iris/pkg/photometry/stars.go:189.95,202.34 6 5
 github.com/observerly/iris/pkg/photometry/stars.go:202.34,208.3 3 85435
 github.com/observerly/iris/pkg/photometry/stars.go:210.2,217.29 4 5
 github.com/observerly/iris/pkg/photometry/stars.go:217.29,223.44 3 10420
-github.com/observerly/iris/pkg/photometry/stars.go:223.44,226.4 2 10171
+github.com/observerly/iris/pkg/photometry/stars.go:223.44,226.4 2 10170
 github.com/observerly/iris/pkg/photometry/stars.go:229.2,229.31 1 5
 github.com/observerly/iris/pkg/photometry/stars.go:232.85,249.26 8 6
-github.com/observerly/iris/pkg/photometry/stars.go:249.26,254.38 2 8580
-github.com/observerly/iris/pkg/photometry/stars.go:254.38,255.41 1 18278
+github.com/observerly/iris/pkg/photometry/stars.go:249.26,254.38 2 8578
+github.com/observerly/iris/pkg/photometry/stars.go:254.38,255.41 1 18272
 github.com/observerly/iris/pkg/photometry/stars.go:255.41,256.13 1 1130
-github.com/observerly/iris/pkg/photometry/stars.go:259.4,259.39 1 17148
-github.com/observerly/iris/pkg/photometry/stars.go:259.39,260.42 1 44126
+github.com/observerly/iris/pkg/photometry/stars.go:259.4,259.39 1 17142
+github.com/observerly/iris/pkg/photometry/stars.go:259.39,260.42 1 44108
 github.com/observerly/iris/pkg/photometry/stars.go:260.42,261.14 1 4636
-github.com/observerly/iris/pkg/photometry/stars.go:265.5,268.53 2 39490
-github.com/observerly/iris/pkg/photometry/stars.go:268.53,275.22 5 224151
+github.com/observerly/iris/pkg/photometry/stars.go:265.5,268.53 2 39472
+github.com/observerly/iris/pkg/photometry/stars.go:268.53,275.22 5 223686
 github.com/observerly/iris/pkg/photometry/stars.go:275.22,276.27 1 7278
-github.com/observerly/iris/pkg/photometry/stars.go:283.3,293.17 5 1302
+github.com/observerly/iris/pkg/photometry/stars.go:283.3,293.17 5 1300
 github.com/observerly/iris/pkg/photometry/stars.go:293.17,295.4 1 180
-github.com/observerly/iris/pkg/photometry/stars.go:295.9,296.24 1 1122
-github.com/observerly/iris/pkg/photometry/stars.go:296.24,298.5 1 3948
-github.com/observerly/iris/pkg/photometry/stars.go:300.4,300.38 1 1122
-github.com/observerly/iris/pkg/photometry/stars.go:303.3,303.19 1 1302
+github.com/observerly/iris/pkg/photometry/stars.go:295.9,296.24 1 1120
+github.com/observerly/iris/pkg/photometry/stars.go:296.24,298.5 1 3930
+github.com/observerly/iris/pkg/photometry/stars.go:300.4,300.38 1 1120
+github.com/observerly/iris/pkg/photometry/stars.go:303.3,303.19 1 1300
 github.com/observerly/iris/pkg/photometry/stars.go:306.2,309.31 3 6
 github.com/observerly/iris/pkg/photometry/stars.go:319.106,321.26 1 3
-github.com/observerly/iris/pkg/photometry/stars.go:321.26,324.71 2 664
-github.com/observerly/iris/pkg/photometry/stars.go:324.71,330.39 3 1283
-github.com/observerly/iris/pkg/photometry/stars.go:330.39,331.40 1 42339
-github.com/observerly/iris/pkg/photometry/stars.go:331.40,336.46 3 1397187
-github.com/observerly/iris/pkg/photometry/stars.go:336.46,338.20 2 1374912
-github.com/observerly/iris/pkg/photometry/stars.go:338.20,340.8 1 1360667
-github.com/observerly/iris/pkg/photometry/stars.go:343.6,345.19 3 1397187
-github.com/observerly/iris/pkg/photometry/stars.go:350.4,353.19 3 1283
+github.com/observerly/iris/pkg/photometry/stars.go:321.26,324.71 2 663
+github.com/observerly/iris/pkg/photometry/stars.go:324.71,330.39 3 1281
+github.com/observerly/iris/pkg/photometry/stars.go:330.39,331.40 1 42273
+github.com/observerly/iris/pkg/photometry/stars.go:331.40,336.46 3 1395009
+github.com/observerly/iris/pkg/photometry/stars.go:336.46,338.20 2 1372734
+github.com/observerly/iris/pkg/photometry/stars.go:338.20,340.8 1 1358493
+github.com/observerly/iris/pkg/photometry/stars.go:343.6,345.19 3 1395009
+github.com/observerly/iris/pkg/photometry/stars.go:350.4,353.19 3 1281
 github.com/observerly/iris/pkg/photometry/stars.go:353.19,355.5 1 0
-github.com/observerly/iris/pkg/photometry/stars.go:357.4,372.44 10 1283
-github.com/observerly/iris/pkg/photometry/stars.go:372.44,374.5 1 1283
-github.com/observerly/iris/pkg/photometry/stars.go:376.4,384.16 2 1283
+github.com/observerly/iris/pkg/photometry/stars.go:357.4,372.44 10 1281
+github.com/observerly/iris/pkg/photometry/stars.go:372.44,374.5 1 1281
+github.com/observerly/iris/pkg/photometry/stars.go:376.4,384.16 2 1281
 github.com/observerly/iris/pkg/photometry/stars.go:388.2,388.14 1 3
 github.com/observerly/iris/pkg/photometry/stars.go:398.143,403.26 3 2
-github.com/observerly/iris/pkg/photometry/stars.go:403.26,411.32 4 417
-github.com/observerly/iris/pkg/photometry/stars.go:411.32,412.33 1 13761
-github.com/observerly/iris/pkg/photometry/stars.go:412.33,414.29 2 454113
-github.com/observerly/iris/pkg/photometry/stars.go:414.29,415.14 1 121764
-github.com/observerly/iris/pkg/photometry/stars.go:417.5,423.47 4 332349
-github.com/observerly/iris/pkg/photometry/stars.go:423.47,425.15 2 329125
-github.com/observerly/iris/pkg/photometry/stars.go:425.15,427.7 1 180226
-github.com/observerly/iris/pkg/photometry/stars.go:429.5,431.13 3 332349
-github.com/observerly/iris/pkg/photometry/stars.go:435.3,435.18 1 417
+github.com/observerly/iris/pkg/photometry/stars.go:403.26,411.32 4 416
+github.com/observerly/iris/pkg/photometry/stars.go:411.32,412.33 1 13728
+github.com/observerly/iris/pkg/photometry/stars.go:412.33,414.29 2 453024
+github.com/observerly/iris/pkg/photometry/stars.go:414.29,415.14 1 121472
+github.com/observerly/iris/pkg/photometry/stars.go:417.5,423.47 4 331552
+github.com/observerly/iris/pkg/photometry/stars.go:423.47,425.15 2 328328
+github.com/observerly/iris/pkg/photometry/stars.go:425.15,427.7 1 179460
+github.com/observerly/iris/pkg/photometry/stars.go:429.5,431.13 3 331552
+github.com/observerly/iris/pkg/photometry/stars.go:435.3,435.18 1 416
 github.com/observerly/iris/pkg/photometry/stars.go:435.18,437.4 1 0
-github.com/observerly/iris/pkg/photometry/stars.go:439.3,442.19 2 417
+github.com/observerly/iris/pkg/photometry/stars.go:439.3,442.19 2 416
 github.com/observerly/iris/pkg/photometry/stars.go:442.19,443.12 1 0
-github.com/observerly/iris/pkg/photometry/stars.go:447.3,453.42 4 417
-github.com/observerly/iris/pkg/photometry/stars.go:453.42,454.43 1 6815
-github.com/observerly/iris/pkg/photometry/stars.go:454.43,457.29 2 116129
-github.com/observerly/iris/pkg/photometry/stars.go:457.29,458.14 1 44028
-github.com/observerly/iris/pkg/photometry/stars.go:461.5,465.47 3 72101
-github.com/observerly/iris/pkg/photometry/stars.go:465.47,467.15 2 71847
-github.com/observerly/iris/pkg/photometry/stars.go:467.15,469.7 1 54125
-github.com/observerly/iris/pkg/photometry/stars.go:471.5,472.18 2 72101
-github.com/observerly/iris/pkg/photometry/stars.go:477.3,481.81 3 417
-github.com/observerly/iris/pkg/photometry/stars.go:481.81,482.12 1 79
+github.com/observerly/iris/pkg/photometry/stars.go:447.3,453.42 4 416
+github.com/observerly/iris/pkg/photometry/stars.go:453.42,454.43 1 6792
+github.com/observerly/iris/pkg/photometry/stars.go:454.43,457.29 2 115600
+github.com/observerly/iris/pkg/photometry/stars.go:457.29,458.14 1 43840
+github.com/observerly/iris/pkg/photometry/stars.go:461.5,465.47 3 71760
+github.com/observerly/iris/pkg/photometry/stars.go:465.47,467.15 2 71506
+github.com/observerly/iris/pkg/photometry/stars.go:467.15,469.7 1 53798
+github.com/observerly/iris/pkg/photometry/stars.go:471.5,472.18 2 71760
+github.com/observerly/iris/pkg/photometry/stars.go:477.3,481.81 3 416
+github.com/observerly/iris/pkg/photometry/stars.go:481.81,482.12 1 78
 github.com/observerly/iris/pkg/photometry/stars.go:486.3,495.25 5 338
 github.com/observerly/iris/pkg/photometry/stars.go:499.2,501.39 2 2
 github.com/observerly/iris/pkg/iris/monochrome.go:29.95,47.2 4 13

pkg/fits/header.go

@@ -141,8 +141,8 @@ Writes a FITS header according to the FITS standard to output bytes buffer
 @see https://fits.gsfc.nasa.gov/standard40/fits_standard40aa-le.pdf
 */
 func (h *FITSHeader) WriteToBuffer(buf *bytes.Buffer) (*bytes.Buffer, error) {
-	// XTENSION = "IMAGE   " needs to be the leading HDR value for a FITS image:
-	writeString(buf, "XTENSION", "IMAGE   ", "FITS Image Extension")
+	// SIMPLE needs to be the leading HDR value:
+	writeBool(buf, "SIMPLE", true, FITS_STANDARD)
 	// BITPIX needs to be the seconda leading HDR value:
 	writeInt(buf, "BITPIX", -32, "Number of bits per data pixel")
 	// NAXIS header: