Fix TextField and Callout TestSelectors #2303
Draft
+61
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,27 +44,14 @@ export const TextFieldTestSelectors = { | |||
| errorMessage: { | |||
There was a problem hiding this comment.
unsure what to do with these features
There was a problem hiding this comment.
label: ["errorMessage", "hint", "label"],That'll fix it.
Comment on lines
40
to
54
| //labels ? something that is a child of the selector rather than a separate feature | ||
| // text: { | ||
| // selector: { | ||
| // method: "ByText", | ||
| // templateVariableNames: ["text"], | ||
| // text: "${text}", | ||
| // }, | ||
| // }, | ||
| // title: { | ||
| // selector: { | ||
| // method: "ByText", | ||
| // templateVariableNames: ["title"], | ||
| // text: "${title}", | ||
| // }, | ||
| // }, |
There was a problem hiding this comment.
Suggested change
| //labels ? something that is a child of the selector rather than a separate feature | |
| // text: { | |
| // selector: { | |
| // method: "ByText", | |
| // templateVariableNames: ["text"], | |
| // text: "${text}", | |
| // }, | |
| // }, | |
| // title: { | |
| // selector: { | |
| // method: "ByText", | |
| // templateVariableNames: ["title"], | |
| // text: "${title}", | |
| // }, | |
| // }, | |
| // label: ["description", "title"], |
| @@ -166,7 +166,7 @@ export const querySelector = <TestSelectors extends FeatureTestSelector>({ | |||
|
|
|||
| return { | |||
| element, | |||
| select, | |||
| selectChild, | |||
There was a problem hiding this comment.
For anyone else looking at this PR, I asked for this renaming as we're gonna have a separate function for selecting labels.
| }, | ||
| }).element; | ||
|
|
||
| expect(element).toHaveErrorMessage(/This field is required/); |
There was a problem hiding this comment.
We can probably have this quoted instead:
Suggested change
| expect(element).toHaveErrorMessage(/This field is required/); | |
| expect(element).toHaveErrorMessage("This field is required"); |
There was a problem hiding this comment.
For some reason, it concatenates the "Error" part, so I can either regex match or add "Error"
Comment on lines
+281
to
+283
| expect(element).toHaveErrorMessage(/This field is required:/); | ||
| expect(element).toHaveErrorMessage(/At least 2 chars/); | ||
| expect(element).toHaveErrorMessage(/No more than 20 chars/); |
There was a problem hiding this comment.
These can all be in quotes.
There was a problem hiding this comment.
Similar to the other comment, toHaveErrorMessage concatenates everything into one string
| @@ -246,6 +247,19 @@ export const Error: StoryObj<typeof TextField> = { | |||
| errorMessage: "This field is required.", | |||
| defaultValue: "", | |||
| }, | |||
| play: async ({ canvasElement, step }) => { | |||
| await step("has visible label", async () => { | |||
There was a problem hiding this comment.
Suggested change
| await step("has visible label", async () => { | |
| await step("has visible error message", async () => { |
| @@ -254,6 +268,21 @@ export const ErrorsList: StoryObj<typeof TextField> = { | |||
| errorMessageList: ["At least 2 chars", "No more than 20 chars"], | |||
| defaultValue: "", | |||
| }, | |||
| play: async ({ canvasElement, step }) => { | |||
| await step("has visible label", async () => { | |||
There was a problem hiding this comment.
Suggested change
| await step("has visible label", async () => { | |
| await step("has visible error messages", async () => { |
Comment on lines
309
to
311
| expect(element).toHaveAccessibleDescription( | ||
| /Specify your destination within the Sol system./, | ||
| ); |
There was a problem hiding this comment.
Suggested change
| expect(element).toHaveAccessibleDescription( | |
| /Specify your destination within the Sol system./, | |
| ); | |
| expect(element).toHaveAccessibleDescription( | |
| "Specify your destination within the Sol system.", | |
| ); |
I think the only places we can't use quotes are Callback, Banner, and Toast.
AnirudhMani-okta
force-pushed
the
am-OKTA-754200-fix-testselectors
branch
from
f378f5e
to
5b8acf7
Compare
AnirudhMani-okta
force-pushed
the
am-OKTA-754200-fix-testselectors
branch
from
5b8acf7
to
7d9b038
Compare
AnirudhMani-okta
force-pushed
the
am-OKTA-754200-fix-testselectors
branch
from
7d9b038
to
071b444
Compare
|
Updated Test Selectors code is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-754200
Summary
Testing & Screenshots