feat: Misc Odyssey updates #2326
Open
+197
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryancunningham-okta
force-pushed
the
bc-expose-mui-stack-and-grid
branch
from
d22c240
to
e0dfc96
Compare
KevinGhadyani-Okta
approved these changes
Aug 27, 2024
KevinGhadyani-Okta
approved these changes
Aug 28, 2024
KevinGhadyani-Okta
requested changes
Aug 28, 2024
Comment on lines
+87
to
+102
| const Grid = ({ | ||
| children, | ||
| columns, | ||
| component = "div", | ||
| container, | ||
| direction, | ||
| item, | ||
| rowSpacing, | ||
| spacing, | ||
| }: GridProps) => { | ||
| return ( | ||
| <MuiGrid | ||
| columns={columns} | ||
| container={container} | ||
| component={component} | ||
| direction={direction} |
There was a problem hiding this comment.
Do we have a Storybook entry for Grid? I'm not sure I completely understand what it does without seeing it.
There was a problem hiding this comment.
Because it's a direct port of a MUI component, I didn't think we'd want a story for it. What do you think?
Comment on lines
+32
to
+34
| const Stack = ({ children, spacing }: StackProps) => { | ||
| return <MuiStack spacing={spacing}>{children}</MuiStack>; | ||
| }; |
There was a problem hiding this comment.
Is this the spacing stuff we're missing from Gen2? Can we get a Storybook entry for it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-796463
Summary
StackandGridutility components from MUIgetOptionLabelprop onAutocompleteTesting & Screenshots