feat: add additional action button and menu slot to table #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -200,6 +202,14 @@ const storybookMeta: Meta<DataTableMetaProps> = { | |||
| control: "boolean", | |||
| name: "[STORY ONLY] Has action buttons in table view?", | |||
| }, | |||
| hasAdditionalActionButton: { | |||
There was a problem hiding this comment.
I feel like the API for this component is already pretty complex. Adding Story only props to the documentation feels like it could cause confusion maybe.
There was a problem hiding this comment.
I see that we've already done this but, feels like we should make an effort to remove them IMHO
bryancunningham-okta
approved these changes
Sep 4, 2024
oktapp-aperture-okta
bot
deleted the
jk-additional-data-table-actions-v2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By popular request (and to achieve parity with that first version of DataTable), this resurrects a feature that was lost as a regression.
Both DataView and DataTable now offer props for additionalActionButton and additionalActionMenuItems, which render arbitrary action button or menu items into the top of the component. This is intended for functionality like an "Add row" action or similar that should live on the table itself, not at the page-level.