Add a new card-like component called AppTile for End-User #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // The ID of the element which the button controls (for instance, a drawer or dialog), if any. | ||
| actionAriaControls?: HTMLAttributes<HTMLElement>["aria-controls"]; | ||
| // Should be true if the button controls a popup element such as a Drawer or Dialog | ||
| actionAriaHasPopup?: HTMLAttributes<HTMLElement>["aria-haspopup"]; |
There was a problem hiding this comment.
This can be other values besides true depending on the menu type. If this opens a dialog the value would be aira-haspopup="dialog"
There was a problem hiding this comment.
Oh, right, just updated the type.
|
@jordankoschei-okta Overall looks fine. Is this a candidate for 2 separate components maybe? Something like |
|
I think basically every AppTile has an action menu. If we split the |
bryancunningham-okta
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.