Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poc: Use minimal okta-auth-js IDX client #3419

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

denysoblohin-okta
Copy link
Contributor

@denysoblohin-okta denysoblohin-okta commented Oct 16, 2023

Description:

Use client from okta/okta-auth-js#1476

Size comparison:
Before:

js/okta-sign-in.next.js (1.47 MiB)
js/okta-sign-in.next.no-polyfill.js (1.32 MiB)

After:

js/okta-sign-in.next.js (1.35 MiB)
js/okta-sign-in.next.no-polyfill.js (1.2 MiB)

PR Checklist

Issue:

Reviewers:

Screenshot/Video:

Downstream Monolith Build:

include: [
/node_modules\/@okta\/okta-auth-js/,
],
sideEffects: false,
Copy link
Contributor Author

@denysoblohin-okta denysoblohin-okta Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is important for proper tree-shaking

@@ -320,10 +320,8 @@ test.requestHooks(requestLogger, mockEnrollAuthenticatorPhoneSmsInvalidPhone)('s
await t.expect(req3Body?.authenticator?.phoneNumber).eql('+1123');
await t.expect(req3Body?.stateHandle).notEql(undefined);

// in gen 2 we re-introspect when clicking return to authenticator,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -98,7 +99,6 @@ Expect.describe('v1/LoginRouter', function() {
router.on('afterError', afterErrorHandler);
if (authClient) {
spyOn(authClient.token, 'getWithoutPrompt').and.callThrough();
spyOn(authClient.token.getWithRedirect, '_setLocation');
Copy link
Contributor Author

@denysoblohin-okta denysoblohin-okta Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_setLocation has been removed in okta/okta-auth-js#1324

@denysoblohin-okta denysoblohin-okta force-pushed the od-test-bundle-idx-lite branch 4 times, most recently from 4c54151 to 79e27c3 Compare October 30, 2023 10:32
@denysoblohin-okta denysoblohin-okta force-pushed the od-test-bundle-idx-lite branch 4 times, most recently from 2d415f4 to 5cf248f Compare October 30, 2023 17:45
AUTHJS_VERSION="7.5.0-ga548153"
use idx as before, but create own lite OktaAuthClient

use 7.5.0-g5555ddd

fix test

fix test

fix test

type fixes

lint fix

fix lint

trigger test

7.5.0-g5ab8355

increase timeout
@denysoblohin-okta denysoblohin-okta changed the title poc: Use lite okta-auth-js client poc: Use minimal okta-auth-js IDX client Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant