-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable e2e tests on SauceLabs in IE11 for Gen3 and Gen2 #3669
Conversation
@@ -2,10 +2,16 @@ | |||
const path = require('path'); | |||
require('@okta/env').config(); | |||
|
|||
// You can use Firefox for e2e testing locally if there is an issue with `chromedriver` | |||
// You need to have `geckodriver` process running (https://github.com/mozilla/geckodriver/releases) | |||
const USE_FIREFOX = !!process.env.USE_FIREFOX; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added Firefox support for local testing due to issues with chromedriver (drivers for Chrome 115+ moved to new URL so need to update wdio/*
to support new Chtome locally)
90eced0
to
d57fa0c
Compare
@@ -39,9 +41,7 @@ export TARGET="CROSS_BROWSER" | |||
export USE_MIN=1 | |||
if ! yarn test:e2e; then | |||
echo "e2e saucelabs test failed! Exiting..." | |||
exit ${TEST_FAILURE} | |||
exit ${PUBLISH_TYPE_AND_RESULT_DIR_BUT_ALWAYS_FAIL} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To save screenshots on fail
}); | ||
|
||
After(async () => { | ||
await browser.deleteCookies(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes more sense to move cookies deletion after logout
e3c7922
to
558dc82
Compare
@@ -6,11 +6,13 @@ source $OKTA_HOME/$REPO/scripts/setup.sh | |||
setup_service java 1.8.222 | |||
setup_service google-chrome-stable 89.0.4389.72-1 | |||
|
|||
export RUN_SAUCE_TESTS=true | |||
export RUN_SAUCE_TESTS=ie11,edge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUN_SAUCE_TESTS
can be list of ie11
, edge
, mobile
separated with ,
mobile
is not included here (and ine2e-saucelabs-v3
as well) because it's flaky (iPad can show "Let's browse!" message for localhost instead of rendering test app), and there is a separate Bacon test named e2e-saucelabs-mobile
that runs tests specially for mobile platforms
Question: do we need edge
? Since MS Edge is based on Chromium.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can leave it edge
on the list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean remove ie11
and leave only edge
?
export RUN_SAUCE_TESTS=edge
But then we lose ability to easily detect IE11 regressions
10a0791
to
6523a5b
Compare
a34a470
to
c45b0d6
Compare
c45b0d6
to
7c5e019
Compare
@@ -1,5 +1,3 @@ | |||
# https://oktainc.atlassian.net/browse/OKTA-545127 | |||
@skip(browserName=/internet.*explorer/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored this test, but it's flaky, so marked all e2e-saucelabs*
Bacon tasks as OPTIONAL
@@ -6,11 +6,13 @@ source $OKTA_HOME/$REPO/scripts/setup.sh | |||
setup_service java 1.8.222 | |||
setup_service google-chrome-stable 89.0.4389.72-1 | |||
|
|||
export RUN_SAUCE_TESTS=true | |||
export RUN_SAUCE_TESTS=ie11,edge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can leave it edge
on the list
Rebasing to close commit distance |
build only gen3 test only ie11 test 1 only test - should fail on IE11 test signup flow test all flows w/o ie.ensureCleanSession fix? revert clear session test1 test2 test retry test - no logout reloadSession remove retry await saveScreenshot + catch restore logout + secreenshot test - only resetPassword all flows fix remove reloadsession enable safari and edge fix iPad and timeouts add browserName to creenshot name enbale gen3 @ ipad log screenshot error reloadSession @ before specFileRetries: 1, clean
try timeouts try driver version test avoidProxy: true .
Revert "removed java and chrome for saucelab tests" This reverts commit 10a0791. removed chrome from saucelabs
96e67d5
to
4d568c9
Compare
Description:
PR Checklist
Issue:
Reviewers:
Screenshot/Video:
Downstream Monolith Build: