-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fingerprint from okta-auth-js #3680
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denysoblohin-okta
force-pushed
the
od-fingerprint-OKTA-418160
branch
from
August 29, 2024 10:39
5f37958
to
f8ee943
Compare
denysoblohin-okta
changed the title
wip: Use fingerprint from okta-auth-js
Use fingerprint from okta-auth-js
Aug 29, 2024
lesterchoi-okta
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@denysoblohin-okta LGTM
denysoblohin-okta
force-pushed
the
od-fingerprint-OKTA-418160
branch
from
September 5, 2024 14:58
245ea36
to
be57991
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates
@okta/okta-auth-js
to version ^7.8.0 and usesauthClient.fingerprint()
to generate a device fingerprint instead of custom code. Applies for all SIW versions.PR Checklist
Issue:
Reviewers:
Screenshot/Video:
Downstream Monolith Build:
https://bacon-go.aue1e.saasure.net/commits?artifact=monolith&page=1&pageSize=6&sha=e7bddd7b4278e59bbe1eab16ac075fbbe61bec11&tab=main