Gen3: Use i18next instead of loc
#3689
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/v3/src/util/locUtil.ts
Outdated
| // No need to escape | ||
| // Need to use raw value for phone numbers containing `‎` | ||
| // React is already safe from XSS | ||
| escapeValue: false, |
There was a problem hiding this comment.
Comment on lines
691
to
693
| password.complexity.minAgeMinutes.description = At least {0} minute(s) must have elapsed since you last changed your password | ||
| password.complexity.minAgeMinutes.description_one = At least {0} minute must have elapsed since you last changed your password | ||
| password.complexity.minAgeMinutes.description_other = At least {0} minutes must have elapsed since you last changed your password |
There was a problem hiding this comment.
Example of using plural forms
lesterchoi-okta
requested review from
mauriciocastillosilva-okta and
nikhilvenkatraman-okta
denysoblohin-okta
force-pushed
the
od-test-i18next
branch
from
e4f527a
to
b69c77d
Compare
Comment on lines
-25
to
+26
| const authCoinConfiguration = getAuthCoinConfiguration(); | ||
| const authCoinConfigByAuthKey = props?.authenticatorKey | ||
| && authCoinConfiguration[props?.authenticatorKey]; | ||
| && getAuthCoinConfiguration()[props.authenticatorKey]; |
There was a problem hiding this comment.
Not a necessary change, just small optimisation.
Noticed that for pages that don't have auth coin there will be a lot of unnecessary loc calls inside getAuthCoinConfiguration()
denysoblohin-okta
force-pushed
the
od-test-i18next
branch
from
7b59fbc
to
afe2347
Compare
denysoblohin-okta
requested review from
glenfannin-okta,
jaredperreault-okta,
leemchale-okta,
robertdamphousse-okta,
shawyu-okta,
shuowu-okta,
trevoring-okta and
vijetmahabaleshwar-okta
as code owners
5 tasks
denysoblohin-okta
force-pushed
the
od-test-i18next
branch
from
afe2347
to
c3a2d57
Compare
denysoblohin-okta
force-pushed
the
od-test-i18next
branch
from
c3a2d57
to
7b29f72
Compare
denysoblohin-okta
force-pushed
the
od-test-i18next
branch
from
7b29f72
to
118d13c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use i18next library for Gen3 instead of Courage's
locfunction for pluralization supportExample: use
instead of single
PR Checklist
Issue:
Reviewers:
Screenshot/Video:
Downstream Monolith Build: