OKTA-747278 : Enable polling on OV same device enroll setup view #3699
Conversation
| } else if (contextualData.devicebootstrap?.setupOVUrl) { | ||
| deviceMap = contextualData.devicebootstrap; | ||
| deviceMap = {...contextualData.devicebootstrap}; |
There was a problem hiding this comment.
make a copy instead of editing the original transaction contextualData in appState, since this was causing the prevTransaction and new transaction to not be identical, causing the SIW to re-render on every poll.
leemchale-okta
force-pushed
the
LM-same-device-enroll-add-polling-OKTA-747278
branch
from
6e8d8c2
to
17cc5c4
Compare
leemchale-okta
changed the title
leemchale-okta
changed the title
| @@ -65,8 +65,7 @@ const Body = BaseFormWithPolling.extend(Object.assign( | |||
| shouldStartPolling = true; | |||
| } else if (['samedevice', 'devicebootstrap'].includes(selectedChannel)) { | |||
| // no selector if the channel is same device or device bootstrap | |||
| // additionally, stop polling as it should be a terminal page | |||
| shouldStartPolling = false; | |||
| shouldStartPolling = true; | |||
There was a problem hiding this comment.
let't separate out same device and device bootstrap here. OV2OV is not shipping out with this together, so we should keep deviceBootstrap polling as false.
Also, let's make a follow up Jira to get test for it.
There was a problem hiding this comment.
follow up jira for test: https://oktainc.atlassian.net/browse/OKTA-798570
|
Looks like you closed https://github.com/atko-eng/okta-core/pull/99376, will flipping that |
@trevoring-okta oh I closed that PR and I made a new PR here: https://github.com/atko-eng/okta-core/pull/100424. Thanks for catching that I updated the description. |
oktapp-aperture-okta
bot
deleted the
LM-same-device-enroll-add-polling-OKTA-747278
branch
Description:
This PR enables polling on the OV Same device enrollment setup screen. This allows the SIW to receive the updated response from the backend when enrollment has been completed in the OV app.
Related back-end change: https://github.com/atko-eng/okta-core/pull/100424
PR Checklist
Issue:
Reviewers:
Screenshot/Video:
Downstream Monolith Build: