-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New data sources #1816
base: master
Are you sure you want to change the base?
New data sources #1816
Conversation
} | ||
_ = d.Set("apps", appsArr) | ||
} else { | ||
_ = d.Set("apps", make([]map[string]interface{}, 0)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this error out when it cannot filter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When no match is found based on the filter?
I don't think so, data sources that return a single instance of a resource throw an error on no match, but this is consistent with the behavior of all of the existing multi-instance data sources I've seen in the provider.
ie users, groups, & group assignments all return an empty array if there are no matches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steveAG I'm going to help here and bring your original work into a PR that I can refactor to use the TF Plugin Framework. Do you have Okta Individual Contributor License Agreement on file with us https://developer.okta.com/cla/ ? |
Okta internal reference https://oktainc.atlassian.net/browse/OKTA-671288 |
Thanks a million @monde! I've been inundated with work and haven't gotten to digging into moving to the framework SDK yet. Yes I have an agreement on file, signed and sent in June 2023. |
Sorry for the multiple resource PR, I caught that in the contribution guidelines when creating the PR, I'll keep that in mind for future contributions, and I can cherry pick these into three PRs if you prefer.
Adds the following data sources:
okta_apps
closes Feature Request: okta_apps data source #1528okta_custom_admin_role
closes Feature Request: okta_admin_role_custom data source #1523okta_group_rules