Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor testing #24

Merged
merged 7 commits into from
Nov 20, 2022
Merged

Refactor testing #24

merged 7 commits into from
Nov 20, 2022

Conversation

newsch
Copy link
Member

@newsch newsch commented Oct 21, 2019

Closes #15.
Closes #11.
Closes #20.

This refactors the run_ocaml functions to raise Errors if ocaml returns an Error/Exception while loading the homework file.

Some other improvements along the way:

  • now returns ocaml error messages directly to the user
  • tests parsing real ocaml output
  • tests parsing finicky doctests
  • refactor main into separate functions/classes
  • type hints
  • typed class for commandline arguments
  • tests for ocaml repl behavior
  • custom exceptions with user-facing hints
  • better test/error parsing

Still todo:

  • Fix remaining doctest parsing edgecases

@newsch newsch added the enhancement New feature or request label Oct 23, 2019
The commit history was lost in an unfortunate accident :((

- Refactor main into separate functions/classes
- type hints
- typed class for commandline arguments
- tests for ocaml repl behavior
- custom exceptions with user-facing hints
- better test/error parsing
- add more development/maintenance notes
- reduce introduction
- add simpler install instructions
@newsch newsch marked this pull request as ready for review November 20, 2022 16:00
@newsch newsch merged commit e9f7722 into master Nov 20, 2022
@newsch newsch deleted the refactor-testing branch November 20, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant