Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent ambiguity of factory methods for matches that match for equality using names 'Equal'/'NotEqual' (use of equality comparer) and 'EqualTo'/'NotEqualTo' (use of comparer) #38

Closed
oliverzick opened this issue Nov 18, 2020 · 0 comments
Closed

Prevent ambiguity of factory methods for matches that match for equality using names 'Equal'/'NotEqual' (use of equality comparer) and 'EqualTo'/'NotEqualTo' (use of comparer) #38

oliverzick opened this issue Nov 18, 2020 · 0 comments
Assignees
@oliverzick
Labels
enhancement New feature or request

Comments

@oliverzick
Copy link
Owner

oliverzick commented Nov 18, 2020 •
edited
Loading

For matching equality using an equality comparer name the factory function Equal/NotEqual.

For matching equality using a comparer name the factory function EqualTo/NotEqualTo to fit naming of matches that do comparison using a comparer like GreaterThanOrEqualTo.
@oliverzick oliverzick self-assigned this Nov 18, 2020
@oliverzick oliverzick added the enhancement New feature or request label Nov 18, 2020
@oliverzick oliverzick changed the title Prevent ambiguity of factory methods for matches that match for equality using an equality comparer or comparer Prevent ambiguity of factory methods for matches that match for equality using names Equal/NotEqual (use of equality comparer) and EqualTo/NotEqualTo (use of comparer) Nov 18, 2020
@oliverzick oliverzick changed the title Prevent ambiguity of factory methods for matches that match for equality using names Equal/NotEqual (use of equality comparer) and EqualTo/NotEqualTo (use of comparer) Prevent ambiguity of factory methods for matches that match for equality using names 'Equal'/'NotEqual' (use of equality comparer) and 'EqualTo'/'NotEqualTo' (use of comparer) Nov 18, 2020
oliverzick added a commit that referenced this issue Nov 18, 2020
@oliverzick
Merge pull request #39 from oliverzick/#38
b3c7e4d 
Resolve #38: Prevent ambiguity of factory methods for matches that match for equality using names 'Equal'/'NotEqual' (use of equality comparer) and 'EqualTo'/'NotEqualTo' (use of comparer)
oliverzick added a commit that referenced this issue Dec 1, 2020
@oliverzick
Update CHANGELOG by improving wording for #38
a83e59f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverzick oliverzick

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oliverzick