-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use all available cores #781
Use all available cores #781
Conversation
When determining what cores are available, we should use the total number from the system, not from the current process
Can one of the admins verify this patch? |
@markbeierl, have you tested the behavior of this PR when deploying multiple UPF instances in the same host? |
Yes, I have tested it, and repeated tests show my affinity staying at |
Although, to note, we have no method of controlling the UPFs affinity when there is more than one on the physical host, so they both fight for processor 0 in that case. |
@sureshmarikkannu, please review this PR. Thanks! |
@markbeierl, you may need to rebase your PR and make the commit(s) appending the |
@markbeierl , Sorry for the delayed review. I want to test multiple scenarios to understand the impact of this change and also want to understand the UPF behavior when we deploy multiple instances of UPF.
So in summary when we scale the UPF, we need to utilize the core's carefully in order to not intersect with other UPF's. @gab-arrobo, @markbeierl Let me know your thoughts. |
close as explained in #780 |
When determining what cores are available, we should use the total number from the system, not from the current process
Addresses #780