Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump pfcpsim to v1.0.1 #841

Closed
wants to merge 2 commits into from

Conversation

gruyaume
Copy link
Contributor

@gruyaume gruyaume commented Aug 6, 2024

Description

Bump the pfcpsim module to v1.0.1. There was a breaking change from 0.1.0 to 1.0.1 that many functions now require an additional urrs parameter that we set to nil here.

@omecproject
Copy link

Can one of the admins verify this patch?

@gruyaume
Copy link
Contributor Author

gruyaume commented Aug 6, 2024

It seems that integration tests are failing for an unrelated reason:

8805: bind: address already in use 

@gab-arrobo
Copy link
Collaborator

It seems that integration tests are failing for an unrelated reason:

8805: bind: address already in use 

I started seeing that issue when this PFCPSIM PR was merged: omec-project/pfcpsim#69

@gab-arrobo
Copy link
Collaborator

Hi @gruyaume, FYI, in this branch (https://github.com/gab-arrobo/upf/tree/update-pfcpsim-dep), I addressed the issue with the integration-tests-bess test. I do not remember why I was not able to complete/address the integration-tests-up4 test.

@gab-arrobo
Copy link
Collaborator

gab-arrobo commented Aug 21, 2024

Hi @gruyaume, FYI, in this branch (https://github.com/gab-arrobo/upf/tree/update-pfcpsim-dep), I addressed the issue with the integration-tests-bess test. I do not remember why I was not able to complete/address the integration-tests-up4 test.

Here is a cleaner version of the changes I made: https://github.com/gab-arrobo/upf/tree/pfcpsim-update, where I integrated the changes I made several months ago in the update-pfcpsim-dep branch with the latest updates in the master branch.

@gab-arrobo
Copy link
Collaborator

Hi @gruyaume, FYI, in this branch (https://github.com/gab-arrobo/upf/tree/update-pfcpsim-dep), I addressed the issue with the integration-tests-bess test. I do not remember why I was not able to complete/address the integration-tests-up4 test.

FYI, here are the details for the issue with the test: https://github.com/gab-arrobo/upf/actions/runs/10482118234

@gab-arrobo
Copy link
Collaborator

Hi @gruyaume, FYI, in this branch (https://github.com/gab-arrobo/upf/tree/update-pfcpsim-dep), I addressed the issue with the integration-tests-bess test. I do not remember why I was not able to complete/address the integration-tests-up4 test.

FYI, here are the details for the issue with the test: https://github.com/gab-arrobo/upf/actions/runs/10482118234

@gruyaume, I was able to resolve the issues with the integration-tests and opened PR #847

@gruyaume gruyaume closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants