-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump pfcpsim to v1.0.1 #841
Conversation
Signed-off-by: guillaume <[email protected]>
Can one of the admins verify this patch? |
It seems that integration tests are failing for an unrelated reason:
|
I started seeing that issue when this PFCPSIM PR was merged: omec-project/pfcpsim#69 |
Hi @gruyaume, FYI, in this branch (https://github.com/gab-arrobo/upf/tree/update-pfcpsim-dep), I addressed the issue with the |
Here is a cleaner version of the changes I made: https://github.com/gab-arrobo/upf/tree/pfcpsim-update, where I integrated the changes I made several months ago in the |
FYI, here are the details for the issue with the test: https://github.com/gab-arrobo/upf/actions/runs/10482118234 |
@gruyaume, I was able to resolve the issues with the |
Description
Bump the pfcpsim module to v1.0.1. There was a breaking change from 0.1.0 to 1.0.1 that many functions now require an additional
urrs
parameter that we set to nil here.