Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugepage feature error in SamSung Galaxy S20 Ultra 5G #584

Closed
John-Yi opened this issue Sep 23, 2021 · 4 comments
Closed

Hugepage feature error in SamSung Galaxy S20 Ultra 5G #584

John-Yi opened this issue Sep 23, 2021 · 4 comments

Comments

@John-Yi
Copy link

John-Yi commented Sep 23, 2021

our app will crash at branch Master src/tbbmalloc/tbbmalloc_internal.h line 457:

if (thpPresent == 'y') {
    MALLOC_ASSERT(hugePageSize != 0, "Huge Page size can't be zero if we found thp existence.");
    thpAvailable = true;
}

I use adb shell to check this phone, the file /sys/kernel/mm/transparent_hugepage/ is exist. But cat the /proc/meminfo, can't find out key word:Hugepagesize, only got a similar word: HugepagePool
image
Is it possible some phone use another word instead of TBB's key word:Hugepagesize?

@isaevil
Copy link
Contributor

isaevil commented Sep 28, 2021

tbbmalloc relies on Hugepagesize variable availability because it seems to be common on Linux systems (I think it is applicable for Android too). I guess Samsung modified Android kernel for its phones somehow because I didn't find any references to HugepagePool variable except of kernel codes for Samsung phone on GitHub.
@alexey-katranov please correct me if I am wrong somewhere

@alexey-katranov
Copy link
Contributor

To tell the truth, I do not know how Hugepagesize is common. However, the crash is not expected if Hugepagesize is not present. I believe it should be deny of service (i.e. do not use huge pages) if the key word is not available.

@John-Yi
Copy link
Author

John-Yi commented Sep 28, 2021

thx for reply. @isaevil @alexey-katranov Will you release an official version to fix this error?

@isaevil
Copy link
Contributor

isaevil commented Nov 11, 2021

Closing since #594 is merged.

@isaevil isaevil closed this as completed Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants