Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check presence of Hugepagesize field #594

Merged
merged 3 commits into from
Nov 2, 2021
Merged

Conversation

isaevil
Copy link
Contributor

@isaevil isaevil commented Sep 30, 2021

Signed-off-by: Ilya Isaev [email protected]

Description

Don't enable HP and THP support if there is no Hugepagesize field in /proc/meminfo

Fixes # - #584

Type of change

  • bug fix - change which fixes an issue
  • new feature - change which adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and for some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

@alexey-katranov @John-Yi

Other information

@isaevil isaevil self-assigned this Sep 30, 2021
@isaevil
Copy link
Contributor Author

isaevil commented Sep 30, 2021

@John-Yi could you please check out this branch on your side?

@John-Yi
Copy link

John-Yi commented Sep 30, 2021

@John-Yi could you please check out this branch on your side?

get it!

@isaevil
Copy link
Contributor Author

isaevil commented Oct 8, 2021

@John-Yi any updates?

@John-Yi
Copy link

John-Yi commented Oct 8, 2021

sorry, I just came back from vacation. I'll report to you next week. @isaevil

@John-Yi
Copy link

John-Yi commented Oct 11, 2021

it works! awesome! @isaevil

@isaevil
Copy link
Contributor Author

isaevil commented Oct 11, 2021

@John-Yi Glad to know.
@alexey-katranov could you please review?

@isaevil isaevil force-pushed the dev/isaevil/fix_thp_detection branch from f90e202 to 5cbc115 Compare October 11, 2021 10:12
@isaevil
Copy link
Contributor Author

isaevil commented Oct 21, 2021

@John-Yi I've made some changes. Could you please confirm that bug is not reproduced again?

Signed-off-by: Ilya Isaev <[email protected]>
Signed-off-by: Ilya Isaev <[email protected]>
@isaevil isaevil force-pushed the dev/isaevil/fix_thp_detection branch from 50647d7 to 275c798 Compare November 1, 2021 10:05
@vlad-nazarov
Copy link

norm 👍

@isaevil isaevil merged commit e82d250 into master Nov 2, 2021
@isaevil isaevil deleted the dev/isaevil/fix_thp_detection branch November 2, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants