Catch exception in lightweight node #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iliamish
changed the title
ivankochin
reviewed
Nov 8, 2021
Signed-off-by: Mishin, Ilya <[email protected]>
Signed-off-by: Mishin, Ilya <[email protected]>
Signed-off-by: Mishin, Ilya <[email protected]>
Signed-off-by: Mishin, Ilya <[email protected]>
Signed-off-by: Mishin, Ilya <[email protected]>
Signed-off-by: Mishin, Ilya <[email protected]>
Signed-off-by: Mishin, Ilya <[email protected]>
Signed-off-by: Mishin, Ilya <[email protected]>
Signed-off-by: Mishin, Ilya <[email protected]>
Signed-off-by: Mishin, Ilya <[email protected]>
Signed-off-by: Mishin, Ilya <[email protected]>
Signed-off-by: Mishin, Ilya <[email protected]>
Signed-off-by: Mishin, Ilya <[email protected]>
Signed-off-by: Mishin, Ilya <[email protected]>
Signed-off-by: Mishin, Ilya <[email protected]>
Iliamish
force-pushed
the
dev/iliamish/fix_exception_in_lightweight_policy
branch
from
c0445be
to
80d0385
Compare
Signed-off-by: Mishin, Ilya <[email protected]>
Co-authored-by: Aleksei Fedotov <[email protected]>
aleksei-fedotov
approved these changes
Nov 12, 2021
Iliamish
changed the title
kboyarinov
pushed a commit
that referenced
this pull request
Dec 27, 2021
* Add raii to aggregator to prevent stuck Signed-off-by: Mishin, Ilya <[email protected]> * Add test Signed-off-by: Mishin, Ilya <[email protected]> * Reuse tbb raii guard Signed-off-by: Mishin, Ilya <[email protected]> * Add header Signed-off-by: Mishin, Ilya <[email protected]> * execute_and_wait lightweight task Signed-off-by: Mishin, Ilya <[email protected]> * remove unused headers Signed-off-by: Mishin, Ilya <[email protected]> * remove space Signed-off-by: Mishin, Ilya <[email protected]> * remove std::function Signed-off-by: Mishin, Ilya <[email protected]> * noexcept lightweight body Signed-off-by: Mishin, Ilya <[email protected]> * fix cmake Signed-off-by: Mishin, Ilya <[email protected]> * fix space Signed-off-by: Mishin, Ilya <[email protected]> * gcc error Signed-off-by: Mishin, Ilya <[email protected]> * declval gateway_type Signed-off-by: Mishin, Ilya <[email protected]> * new tests Signed-off-by: Mishin, Ilya <[email protected]> * template tests Signed-off-by: Mishin, Ilya <[email protected]> * macro TBB_USE_EXCEPTIONS Signed-off-by: Mishin, Ilya <[email protected]> * Apply suggestions from code review Co-authored-by: Aleksei Fedotov <[email protected]> Co-authored-by: Aleksei Fedotov <[email protected]>
Is it requirement reflected in the oneTBB specification? I think it should. |
PR regarding the reflection: uxlfoundation/oneAPI-spec#407. @akukanov @alexey-katranov |
|
Another concern is that, though backward compatibility is not formally broken, the behavior of codes that use lightweight policies may implicitly change, resulting in a possible performance loss. @alexey-katranov, @aleksei-fedotov, have you considered some form of a warning to be issued when lightweight policies are applied without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If user code throws exception inside body of lightweight node, that deadlock graph. In this patch we require from user mark body
noexceptfor using lightweight policy. If body can throw exception, policy implicitly implements queuing behavior.Fixes # - #420
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information