-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving task_group_exptensions out of the preview #668
Moving task_group_exptensions out of the preview #668
Conversation
- all but : - is_inside_task - scheduller bypass Signed-off-by: Anton Potapov <[email protected]>
72bacf2
to
0febcaf
Compare
Co-authored-by: Ilya Isaev <[email protected]>
- removed duplicated test case Signed-off-by: Anton Potapov <[email protected]>
Should we check somewhere for |
- replaced exceptions with asserts for undefined behaviour Signed-off-by: Anton Potapov <[email protected]>
6e0b42b
to
5cb7016
Compare
- added test for task_handle being non copyable Signed-off-by: Anton Potapov <[email protected]>
added |
oneapi::tbb::task_handle h; | ||
|
||
oneapi::tbb::task_group tg; | ||
std::atomic<bool> run {false}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same about run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
TEST_CASE("Task handle blocks wait"){ | ||
oneapi::tbb::task_group tg; | ||
|
||
std::atomic<bool> completed {false}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make completed
to be non-atomic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Co-authored-by: Alex <[email protected]>
- made some flags in the tests non-atomic for TSAN to raise a flag if implementation is incorrect Signed-off-by: Anton Potapov <[email protected]>
Moving task_group_exptensions out of the preview - moved all but : - is_inside_task - scheduller bypass - replaced exceptions with asserts for undefined behavior - made some flags in the tests non-atomic for TSAN to raise a flag if implementation is incorrect Signed-off-by: Anton Potapov <[email protected]> Co-authored-by: Ilya Isaev <[email protected]> Co-authored-by: Alex <[email protected]>
Signed-off-by: Anton Potapov <[email protected]>
Signed-off-by: Anton Potapov <[email protected]>
Description
task_handle
and related out of Preview features to be aligned withoneAPI V1.1 rev 1 :
Following features, as not part of the spec are still preview ones:
is_inside_task
functiontask_handle
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@
to send notificationsOther information