Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move oneapi::tbb::concurrent_hash_map heterogeneous extensions from preview #672

Merged

Conversation

kboyarinov
Copy link
Contributor

@kboyarinov kboyarinov commented Nov 29, 2021

Description

Move heterogeneous overloads for concurrent_hash_map lookup, insert and erase out of preview:

  • Remove TBB_PREVIEW_CONCURRENT_HASH_MAP_EXTENSIONS macro around the overloads

  • Move tests from tbb folder to conformance

  • Remove the documentation from reference

  • - git commit message contains appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add respective label(s) to PR if you have permissions

  • bug fix - change which fixes an issue
  • new feature - change which adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and for some bug fixes
  • not needed

Documentation

  • updated in this PR
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

Copy link
Contributor

@alexey-katranov alexey-katranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests seem slightly simplified, they do not test concurrency and more than one heterogeneous key presence. Surely, it is not a blocker, feel free to commit.

@kboyarinov kboyarinov merged commit fc8717e into master Dec 3, 2021
@kboyarinov kboyarinov deleted the dev/kboyarinov/heterogeneous_lookup_chmap_spec_1_1 branch December 3, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants