Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy tbb.lib only with MSVC #679

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Copy tbb.lib only with MSVC #679

merged 1 commit into from
Dec 6, 2021

Conversation

MehdiChinoune
Copy link
Contributor

Description

Don't copy tbb.lib to installation for MinGW, as It is not needed and not used by MinGW.
Restrict it MSVC.

  • - git commit message contains appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

  • bug fix - change which fixes an issue
  • new feature - change which adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and for some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

Other information

@AlexVeprev
Copy link
Contributor

Technically LGTM, @alexey-katranov, do you have any concerns on the proposal? See the description.

@alexey-katranov alexey-katranov merged commit f5de7b0 into oneapi-src:master Dec 6, 2021
@MehdiChinoune MehdiChinoune deleted the patch-2 branch December 6, 2021 14:41
kboyarinov pushed a commit that referenced this pull request Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants