Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_limiter_node: Build issue: GCC 4.8 bug #693

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

vlserov
Copy link

@vlserov vlserov commented Dec 21, 2021

Description

Class template inheritance doesn't work well with function-local types.
Moving class definition to global scope
GCC Commit

Fixes # - issue number(s) if exists

  • - git commit message contains appropriate signed-off-by string (see CONTRIBUTING.md for details)

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add respective label(s) to PR if you have permissions

  • bug fix - change which fixes an issue
  • new feature - change which adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and for some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

@anton-potapov

Other information

Class template inheritance doesn't work well with function-local types
Move class definution to global scope

Signed-off-by: Serov, Vladimir <[email protected]>
Copy link
Contributor

@anton-potapov anton-potapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anton-potapov anton-potapov merged commit 534428d into master Dec 22, 2021
@anton-potapov anton-potapov deleted the dev/vserov/limiter_node_build_issue branch December 22, 2021 13:52
kboyarinov pushed a commit that referenced this pull request Dec 27, 2021
Class template inheritance doesn't work well with function-local types
Move class definition to global scope

Signed-off-by: Serov, Vladimir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants