feat(flipt): Add Flipt provider in openfeature-js #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoofi Quansah <[email protected]>
…he underlying client Signed-off-by: Yoofi Quansah <[email protected]>
markphelps
reviewed
Jan 16, 2024
Signed-off-by: Yoofi Quansah <[email protected]>
Signed-off-by: Yoofi Quansah <[email protected]>
beeme1mr
reviewed
Jan 17, 2024
|
Hey @yquansah, thanks for the PR. I've left some feedback. Please let me know if you have any questions! |
|
Could you also please add yourself as the component owner? This will automatically add you as a reviewer to any change that affects this provider. https://github.com/open-feature/js-sdk-contrib/blob/main/.github/component_owners.yml |
|
@beeme1mr Thanks for the review! I am going to address these today |
…l Error, documentation, and CI Signed-off-by: Yoofi Quansah <[email protected]>
Signed-off-by: Yoofi Quansah <[email protected]>
|
@yquansah please add |
Signed-off-by: Yoofi Quansah <[email protected]>
|
@beeme1mr Thanks!! |
beeme1mr
approved these changes
Jan 19, 2024
Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Mark Phelps <[email protected]>
|
Thanks all 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Add Flipt openfeature provider.
Related Issues
Notes
Follow-up Tasks
How to test