-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flipt): Add Flipt provider in openfeature-js #724
Conversation
Signed-off-by: Yoofi Quansah <[email protected]>
…he underlying client Signed-off-by: Yoofi Quansah <[email protected]>
Signed-off-by: Yoofi Quansah <[email protected]>
Signed-off-by: Yoofi Quansah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!!
Hey @yquansah, thanks for the PR. I've left some feedback. Please let me know if you have any questions! |
Could you also please add yourself as the component owner? This will automatically add you as a reviewer to any change that affects this provider. https://github.com/open-feature/js-sdk-contrib/blob/main/.github/component_owners.yml |
@beeme1mr Thanks for the review! I am going to address these today |
…l Error, documentation, and CI Signed-off-by: Yoofi Quansah <[email protected]>
Signed-off-by: Yoofi Quansah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yquansah, thanks this looks great. I had one question and requested a change to the readme. We should be good to merge after that. Thanks!
@yquansah please add |
Signed-off-by: Yoofi Quansah <[email protected]>
@beeme1mr Thanks!! |
Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Mark Phelps <[email protected]>
Thanks all 🙏🏻 |
This PR
Add Flipt openfeature provider.
Related Issues
Notes
Follow-up Tasks
How to test