Processor instance per data type #10664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10664 +/- ##
=======================================
Coverage 92.33% 92.33%
=======================================
Files 403 403
Lines 18734 18746 +12
=======================================
+ Hits 17298 17310 +12
Misses 1076 1076
Partials 360 360 ☔ View full report in Codecov by Sentry. |
djaglowski
force-pushed
the
processor-instance-per-type
branch
from
debc06b
to
77734e9
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept implementation for what it would look like to instantiate processors on a per data type basis, as opposed to the current behavior which is per pipeline. See #10534 for detailed discussion about this idea.
This would mean that we treat processors more like receivers and exporters.
processorssection in the config is no longer conceptually different than that of the top-levelreceiversandexporterssections, meaning that all three would treat each configuration as a declaration of an instance, rather than treating processor configurations as a declaration of an abstract configuration.While I don't consider this PR complete, I want to put it up for review to demonstrate that it's not a terribly complicated implementation change. If this functionality were to move forward I would expect that it is behind a feature gate and accompanied by documentation.