[chore] avoid mixing pointer and non-pointer receiver on struct functions #10667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10667 +/- ##
=======================================
Coverage 92.33% 92.33%
=======================================
Files 403 403
Lines 18734 18734
=======================================
Hits 17298 17298
Misses 1076 1076
Partials 360 360 ☔ View full report in Codecov by Sentry. |
crobert-1
approved these changes
Jul 19, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Not stale, waiting for reviews. |
codeboten
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an IDE warning about mixing receiver types.