Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/ballast] Remove the deprecated memory ballast extension #10671

Merged
merged 11 commits into from
Sep 4, 2024

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Jul 19, 2024

Description

This PR removes the deprecated memory ballast extension and all the logic in place in memorylimiter and service that was using it.

Link to tracking issue

Related to #8343. I don't want to close it until the helm chart is updated.

Testing

Unit tests

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner July 19, 2024 21:48
.chloggen/remove-ballast-extension.yaml Show resolved Hide resolved
cmd/otelcorecol/go.mod Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (48b11ba) to head (420efda).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10671      +/-   ##
==========================================
+ Coverage   92.22%   92.23%   +0.01%     
==========================================
  Files         409      406       -3     
  Lines       19134    19101      -33     
==========================================
- Hits        17646    17618      -28     
+ Misses       1127     1123       -4     
+ Partials      361      360       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we possibly split this process in more steps?

For example, a first step before outright removal can be:

Then a second step can be removing it from the official binaries while keeping a source-only release, and a final step would be removing the source code entirely.

I think this would solve our immediate issue and make the deprecation process more manageable (not all users would get this removed at the same time, so support requests are more easy to manage).

I know this is more annoying but

  • this extension has been here since forever
  • we don't know which users have been listening to our deprecations

so I think we need to be gentle and divide this into steps

codeboten pushed a commit that referenced this pull request Jul 23, 2024
#### Description

This PR removes all ballast logic from service. This effectively
deprecates the ballastextension as including the extension with this
service would do nothing.

Related to
#10671

#### Link to tracking issue
Closes
#8342

#### Testing
Unit tests.
Copy link
Contributor

github-actions bot commented Aug 7, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@songy23 songy23 requested a review from mx-psi August 29, 2024 16:00
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we seen any users complaining after open-telemetry/opentelemetry-collector-releases/pull/607? I see #10995, have we had any other reports?

If #10995 is the only one, I am comfortable merging this

@TylerHelmuth
Copy link
Member Author

So far I've only seen #10995

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oki, then I would propose we wait until, say, Wednesday next week and merge if we don't get more reports

@mx-psi mx-psi merged commit c9058e6 into open-telemetry:main Sep 4, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants