-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] avoid flaky test by using port 0 #10678
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10678 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 403 403
Lines 18722 18722
=======================================
Hits 17296 17296
Misses 1066 1066
Partials 360 360 ☔ View full report in Codecov by Sentry. |
@codeboten please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atoulme are there other places in the code where this should be changed then?
yes, there is at least another flaky test that leverages and reuses the same port in between runs, but it specifically tests telemetry and makes calls to the server, which makes things more difficult to move over to this model.
|
Description
Use port zero since we just start and stop the server.
Link to tracking issue
Fixes #9772