Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confighttp] delete ClientConfig.CustomRoundTripper #10686

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jul 21, 2024

Description

Delete deprecated ClientConfig.CustomRoundTripper

Link to tracking issue

Fixes #8627

@atoulme atoulme requested a review from a team as a code owner July 21, 2024 07:31
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.40%. Comparing base (7d5b1ba) to head (b3b3e98).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10686      +/-   ##
==========================================
+ Coverage   92.38%   92.40%   +0.01%     
==========================================
  Files         403      403              
  Lines       18729    18725       -4     
==========================================
  Hits        17303    17303              
+ Misses       1066     1063       -3     
+ Partials      360      359       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to check for this, thanks.

@atoulme
Copy link
Contributor Author

atoulme commented Jul 22, 2024

No problem, happy to help!

@atoulme atoulme added the ready-to-merge Code review completed; ready to merge by maintainers label Jul 25, 2024
@mx-psi mx-psi merged commit ff9ae6b into open-telemetry:main Jul 26, 2024
69 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[confmap] Should not marshal functions/channels by default
3 participants