-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] set default transport defaults on NewDefaultClientConfig #10688
[chore] set default transport defaults on NewDefaultClientConfig #10688
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10688 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 406 406
Lines 18987 18991 +4
=======================================
+ Hits 17400 17404 +4
Misses 1227 1227
Partials 360 360 ☔ View full report in Codecov by Sentry. |
9cd98e4
to
72346af
Compare
There's some errors in the |
open-telemetry/opentelemetry-collector-contrib#34477 is open to unblock. |
|
Description
Set the defaults on
NewDefaultClientConfig
. This change is a no-op since those defaults are set if the value is not set.Add documentation to all fields as well.
Link to tracking issue
#9478