Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile support in receiver #10690

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Jul 22, 2024

Description

This follows #10530, and adds profiles support into receivers.

Link to tracking issue

See #10375

cc @mx-psi

@dmathieu dmathieu force-pushed the receiverprofiles branch 3 times, most recently from 390e0ff to 9bc4479 Compare July 22, 2024 08:56
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Project coverage is 92.06%. Comparing base (ea2940d) to head (7aa3f4d).

Files Patch % Lines
receiver/internal/factory.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10690      +/-   ##
==========================================
- Coverage   92.11%   92.06%   -0.06%     
==========================================
  Files         403      404       +1     
  Lines       18806    18819      +13     
==========================================
+ Hits        17323    17325       +2     
- Misses       1123     1134      +11     
  Partials      360      360              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu marked this pull request as ready for review July 22, 2024 09:10
@dmathieu dmathieu requested a review from a team as a code owner July 22, 2024 09:10
@dmathieu dmathieu requested a review from songy23 July 22, 2024 09:10
@dmathieu
Copy link
Member Author

Moving back to draft pending #10692 (which will reduce the size of this PR).

@dmathieu dmathieu marked this pull request as draft July 22, 2024 12:15
@dmathieu dmathieu marked this pull request as ready for review July 23, 2024 13:03
@dmathieu
Copy link
Member Author

This is ready for review again.
The windows-unittest failure appears unrelated.

@mx-psi mx-psi added this to the Profiling support milestone Jul 23, 2024
@mx-psi
Copy link
Member

mx-psi commented Jul 31, 2024

@dmathieu can you fix the merge conflict?

@mx-psi mx-psi merged commit 75fd259 into open-telemetry:main Jul 31, 2024
49 of 50 checks passed
@dmathieu dmathieu deleted the receiverprofiles branch July 31, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants