-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document collector's internal telemetry #10695
Document collector's internal telemetry #10695
Conversation
Signed-off-by: Alex Boten <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10695 +/- ##
==========================================
- Coverage 92.39% 91.60% -0.80%
==========================================
Files 403 404 +1
Lines 18744 18990 +246
==========================================
+ Hits 17318 17395 +77
- Misses 1066 1235 +169
Partials 360 360 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alex Boten <[email protected]>
docs/rfcs/internal-telemetry.md
Outdated
to provide this information. The information in this document will be updated once | ||
the OTEP lands to follow its recommendations. | ||
|
||
## Internal telemetry properties |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we get away with adding everything from this point on to the observability.md and call it a day? This accurately describes our existing telemetry expectations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved, please take a look
Co-authored-by: Daniel Jaglowski <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Signed-off-by: Alex Boten <[email protected]>
Decided to try @TylerHelmuth's suggestion of moving the details of the current state of telemetry into observability.md instead of creating a separate doc. Since it's just documenting what's already there, i think that makes more sense. |
Co-authored-by: Pablo Baeyens <[email protected]>
@djaglowski can you take a look, want to make sure your comments are addressed |
This documents is to provide guidelines for component authors when making decisions about what the telemetry of their components should look like in order to provide a consistent experience to end users.