feat: adding new metric: up down sum observer #1272
Merged
+328
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obecny
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
OlivierAlbertini and
vmarchaud
as code owners
obecny
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## master #1272 +/- ##
==========================================
+ Coverage 93.03% 93.24% +0.20%
==========================================
Files 120 137 +17
Lines 2931 3878 +947
Branches 590 790 +200
==========================================
+ Hits 2727 3616 +889
- Misses 204 262 +58
|
mayurkale22
reviewed
Jul 2, 2020
|
What is the plan to export this new Metric type to Prometheus exporter? |
This is currently already exported as point has value which is number and this number will be exported |
mayurkale22
reviewed
Jul 2, 2020
dyladan
reviewed
Jul 2, 2020
lykkin
suggested changes
Jul 2, 2020
mayurkale22
approved these changes
Jul 3, 2020
vmarchaud
reviewed
Jul 4, 2020
| @@ -30,7 +30,7 @@ const NOOP_CALLBACK = () => {}; | |||
| */ | |||
| export abstract class BaseObserverMetric extends Metric<BoundObserver> | |||
| implements api.BaseObserver { | |||
| protected _callback: (observerResult: api.ObserverResult) => void; | |||
| protected _callback: (observerResult: api.ObserverResult) => unknown; | |||
There was a problem hiding this comment.
not sure why you changed the void to a unknown ?
There was a problem hiding this comment.
because this might or not return something
dyladan
approved these changes
Jul 7, 2020
|
@open-telemetry/javascript-approvers ^^ |
naseemkullah
reviewed
Jul 9, 2020
naseemkullah
reviewed
Jul 9, 2020
| }); | ||
| } | ||
|
|
||
| // sync callback in case you don't need to wait for value |
There was a problem hiding this comment.
👍
Great to provide both examples.
naseemkullah
reviewed
Jul 9, 2020
naseemkullah
approved these changes
Jul 9, 2020
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Mayur Kale <[email protected]>
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Mayur Kale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes