Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating aggregator MinMaxLastSumCount and use it for value observer and value recorder #1276

Merged
merged 5 commits into from
Jul 6, 2020

Conversation

obecny
Copy link
Member

@obecny obecny commented Jul 3, 2020

Which problem is this PR solving?

Short description of the changes

  • It adds last value to current aggregator MinMaxSumCount which becomes now MinMaxLastSumCount, then it is used for ValueObserver and ValueRecorder

@obecny obecny self-assigned this Jul 3, 2020
@obecny obecny added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 3, 2020
@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #1276 into master will increase coverage by 0.32%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #1276      +/-   ##
==========================================
+ Coverage   93.09%   93.42%   +0.32%     
==========================================
  Files         133      132       -1     
  Lines        3764     3755       -9     
  Branches      761      761              
==========================================
+ Hits         3504     3508       +4     
+ Misses        260      247      -13     
Impacted Files Coverage Δ
packages/opentelemetry-metrics/src/export/types.ts 100.00% <ø> (ø)
...ckages/opentelemetry-metrics/src/export/Batcher.ts 91.30% <50.00%> (ø)
...pentelemetry-exporter-prometheus/src/prometheus.ts 89.89% <100.00%> (+2.02%) ⬆️
...trics/src/export/aggregators/MinMaxLastSumCount.ts 100.00% <100.00%> (ø)
...ntelemetry-metrics/src/export/aggregators/index.ts 100.00% <100.00%> (ø)

@dyladan dyladan added the enhancement New feature or request label Jul 6, 2020
@mayurkale22 mayurkale22 added the Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Jul 6, 2020
@obecny obecny merged commit d454492 into open-telemetry:master Jul 6, 2020
@obecny obecny deleted the minmaxlastsumcount branch July 6, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create MinMaxLastSumCount Agrregator
5 participants