Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(zipkin): export ExporterConfig #1474

Merged
merged 4 commits into from
Nov 2, 2020

Conversation

shivkanya9146
Copy link
Contributor

@shivkanya9146 shivkanya9146 commented Aug 28, 2020

Fixes #1453

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #1474 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1474   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files         165      165           
  Lines        5066     5066           
  Branches     1037     1037           
=======================================
  Hits         4620     4620           
  Misses        446      446           

@obecny
Copy link
Member

obecny commented Aug 31, 2020

Please fix the description

@dyladan
Copy link
Member

dyladan commented Sep 2, 2020

@shivkanya9146 I updated the issue description to mention the issue it fixes. in the future can you make sure to make descriptive PR descriptions so that people know what they are reviewing?

@shivkanya9146 shivkanya9146 changed the title chore(zipkin): export ExporterConfig chore(jaeger): export ExporterConfig Sep 8, 2020
@shivkanya9146
Copy link
Contributor Author

@shivkanya9146 I updated the issue description to mention the issue it fixes. in the future can you make sure to make descriptive PR descriptions so that people know what they are reviewing?

ok, will make will sure in future.

@dyladan
Copy link
Member

dyladan commented Sep 8, 2020

Title says jaeger but fix is actually applied to zipkin (opposite of #1478)

@shivkanya9146 shivkanya9146 changed the title chore(jaeger): export ExporterConfig chore(zipkin): export ExporterConfig Sep 9, 2020
@shivkanya9146
Copy link
Contributor Author

Title says jaeger but fix is actually applied to zipkin (opposite of #1478)

Done

@obecny
Copy link
Member

obecny commented Sep 29, 2020

@shivkanya9146 can you please resolve the conflicts ?

@dyladan dyladan added the enhancement New feature or request label Nov 2, 2020
@dyladan dyladan merged commit 6216b00 into open-telemetry:master Nov 2, 2020
pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
* docs: document component maturity levels

* docs: link maturity levels from README

* Typo

Co-authored-by: Marc Pichler <[email protected]>

* Link header instead of owner

---------

Co-authored-by: Marc Pichler <[email protected]>
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 13, 2024
* docs: document component maturity levels

* docs: link maturity levels from README

* Typo

Co-authored-by: Marc Pichler <[email protected]>

* Link header instead of owner

---------

Co-authored-by: Marc Pichler <[email protected]>
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 16, 2024
* docs: document component maturity levels

* docs: link maturity levels from README

* Typo

Co-authored-by: Marc Pichler <[email protected]>

* Link header instead of owner

---------

Co-authored-by: Marc Pichler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ZipkinExporter] ExporterConfig needs to be exported since it is API
4 participants